Workiva / wGulp

Opinionated Suite of Gulp Tasks for JavaScript and TypeScript projects.
Apache License 2.0
12 stars 9 forks source link

Pin node-sass to satisfy upstream dependency #160

Closed jimhotchkin-wf closed 9 years ago

jimhotchkin-wf commented 9 years ago

Code Review

Ultimate Problem

An upstream dependency of wGulp was itself pulling in a beta version of node-sass which was causing errors in some projects when they attempted to run gulp sass.

Proposed Solution

Add node-sass: 3.3.0 to wGulp's dependencies, which satisfies the upstream dependency and prevents the beta version from being included in the dependency tree.

jimhotchkin-wf commented 9 years ago

@maxwellpeterson-wf @trentgrover-wf @evanweible-wf @dustinlessard-wf

Just a suggestion, based on our experiences. Thanks!

trentgrover-wf commented 9 years ago

closing as duplicate of https://github.com/Workiva/wGulp/pull/159/