Workiva / wGulp

Opinionated Suite of Gulp Tasks for JavaScript and TypeScript projects.
Apache License 2.0
12 stars 9 forks source link

Change configuration options and tasks that use underscores to camelCase #73

Closed maxwellpeterson-wf closed 10 years ago

maxwellpeterson-wf commented 10 years ago

Fixes #39 . Must be reviewed/merged after #63 as it was branched off of that initiative.

Problem

Some of the tasks, filenames, and configuration options in wGulp inconsistently use underscores and camelCase. This makes it hard for consumers to keep track of configuration options and task names.

Solution

Switch uses of underscores to use camelCase.

This aligns with @shanesizer-wf 's motto of "The name is the name is the name."

Testing (How to +10)

@trentgrover-wf @shanesizer-wf @evanweible-wf

trentgrover-wf commented 10 years ago

+1 from looking at this diff (will check for +10 once the other PR is complete and merged): https://github.com/Workiva/wGulp/compare/depTree...camelCase?expand=1

shanesizer-wf commented 10 years ago

A PITA, but I like the consistency of the result. +1

maxwellpeterson-wf commented 10 years ago

@trentgrover-wf @evanweible-wf This is ready now that #63 was merged

trentgrover-wf commented 10 years ago

@maxwellpeterson-wf getting errors when testing the examples: Task 'minify:js' is not in your gulpfile

maxwellpeterson-wf commented 10 years ago

@trentgrover-wf oops! fixed

trentgrover-wf commented 10 years ago

+10

@charliekump-wf ready for merge

charliekump-wf commented 10 years ago

QA Resource Approval: +1

Merging into master.