search

Workiva / wGulp

Opinionated Suite of Gulp Tasks for JavaScript and TypeScript projects.
Apache License 2.0
12 stars 9 forks source link

jspm bundle failures does not fail build #99

Open maxwellpeterson-wf opened 10 years ago

maxwellpeterson-wf commented 10 years ago

A smithy build of a wGulp project can pass successfully even if the bundle step (using jspm bundle) fails.

Example: https://ci.webfilings.com/build/141224

guybedford-wf commented 10 years ago

I've added a fix in https://github.com/jspm/jspm-cli/commit/a7826d13884c2c2c2ab96ee8411d1aebc2388c86 to ensure an error code is returned for failed bundles like failed installs.

Also running jspm through the API would allow error detection as well.

maxwellpeterson-wf commented 10 years ago

Thanks! Ah yes - I should look at running it through the API instead.