Closed evanweible-wf closed 3 years ago
No security relevant content was detected by automated scans.
aviary.yaml
coverage of security relevant codeQuestions or Comments? Reach out on Slack: #support-infosec.
QA +1 The instructions aren't quite right (it seems to be just --, not --webdev-args), but it runs and serves with that.
Oh whoops, sorry about that! Got mixed up between ddev serve
and webdev_proxy serve
- thanks for the qa!
@Workiva/release-management-p
When trying to pass an option like
--hostname=0.0.0.0
from webdev_proxy to the webdev process, we were unintentionally passing the option through twice, which causes a newer version of the build daemon to fail to start.This PR fixes this by stripping that option and its value out after parsing it.
Additionally, CI has been moved to Github and tests have been updated to work with the latest Chrome and Chromedriver.
Testing
dev_dependencies
(pub global activate
from path seems to run a pub get which will fail b/c two of the dev deps needed for tests require dart 2.12+)pub global run webdev_proxy --webdev-args="--hostname=0.0.0.0"
in any project with aweb/