Workiva / webdev_proxy

A simple HTTP proxy for the webdev serve command (a tool authored by the dart team) that adds support for rewriting certain requests, namely rewriting 404s to instead serve the root index (/index.html). This allows developers to work on browser applications (like our own) that use HTML5 routing while still being able to refresh and/or navigate directly to deep links.
Other
11 stars 6 forks source link

CPLAT-15165 Fix bug when using `--hostname` option #14

Closed evanweible-wf closed 3 years ago

evanweible-wf commented 3 years ago

When trying to pass an option like --hostname=0.0.0.0 from webdev_proxy to the webdev process, we were unintentionally passing the option through twice, which causes a newer version of the build daemon to fail to start.

This PR fixes this by stripping that option and its value out after parsing it.

Additionally, CI has been moved to Github and tests have been updated to work with the latest Chrome and Chromedriver.

Testing

aviary3-wk commented 3 years ago

Security Insights

No security relevant content was detected by automated scans.

Action Items

alanknight-wk commented 3 years ago

QA +1 The instructions aren't quite right (it seems to be just --, not --webdev-args), but it runs and serves with that.

evanweible-wf commented 3 years ago

Oh whoops, sorry about that! Got mixed up between ddev serve and webdev_proxy serve - thanks for the qa!

evanweible-wf commented 3 years ago

@Workiva/release-management-p