Workiva / webdev_proxy

A simple HTTP proxy for the webdev serve command (a tool authored by the dart team) that adds support for rewriting certain requests, namely rewriting 404s to instead serve the root index (/index.html). This allows developers to work on browser applications (like our own) that use HTML5 routing while still being able to refresh and/or navigate directly to deep links.
Other
11 stars 6 forks source link

Replace deprecated commands with new dart commands #19

Closed sourcegraph-wk closed 2 years ago

sourcegraph-wk commented 2 years ago

This Sourcegraph batch replaces deprecated commands from the Dart SDK with the new ones. All new CLI commands now live under the main dart executable. See this issue for the details https://github.com/dart-lang/sdk/issues/46100

This PR might need to be checked or tweaked for possible errors in the arguments to dart analyze and dart format since they take slightly different arguments than the original. In most cases for analyze all the arguments can be removed and it can just be dart analyze.

Some of the argument changes were difficult to match and replace in an automated way. Since there are only a few places that might break, it'll be easier to let the batch create the PR and then manually adjust them.

Argument changes for dartfmt -> dart format

-w should be removed automatically since overwriting files is now the default. But, if you spot one, remove it. --dry-run is not a supported argument now. Replace with --set-exit-if-changed -o none

repos that look like they will need updates for dart format

Argument changes for dartanalyzer -> dart analyze

--no-hints and --no-lints are removed

repos that look like they will need updates for dart analyze

QA steps:

_Created by Sourcegraph batch change Workiva/dart_commands._

aviary-wf commented 2 years ago

Security Insights

No security relevant content was detected by automated scans.

Action Items

evanweible-wf commented 2 years ago

QA +1 CI passes @Workiva/release-management-p