CPLAT-6186 Ensure that the webdev_proxy process always exits

Workiva / webdev_proxy

A simple HTTP proxy for the webdev serve command (a tool authored by the dart team) that adds support for rewriting certain requests, namely rewriting 404s to instead serve the root index (/index.html). This allows developers to work on browser applications (like our own) that use HTML5 routing while still being able to refresh and/or navigate directly to deep links.

Other

11 stars 6 forks source link

CPLAT-6186 Ensure that the webdev_proxy process always exits #2

Closed evanweible-wf closed 5 years ago

evanweible-wf commented 5 years ago

Changes

When webdev_proxy starts a webdev serve child process and some other process connects to it (e.g. a chrome tab), the parent process will not exit on its own until the connected process stops listening, even if the webdev serve process is killed.

To solve this, the webdev_proxy exectuable now calls dart:io's exit() method rather than passively setting the exitCode, which will force the process to exit even in the above scenario.

Testing

Run pub run webdev_proxy serve -- test
Load http://localhost:8080 in a browser
Return to terminal with running process and interrupt the process with a ctrl + c
Verify that the process exits cleanly and does not hang

rmconsole-wf commented 5 years ago

Merge Requirements Met :white_check_mark:

Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment.

    When this pull is merged I will add it to the following release:
    Version: webdev_proxy 0.1.0
    Release Ticket(s): RM-53263

Note: This is a shortened report. Click here to view Rosie's full evaluation. Last updated on Thursday, June 20 02:34 PM CST

aviary-wf commented 5 years ago

Security Insights

No security relevant content was detected by automated scans.

Action Items

Review PR for security impact; comment "security review required" if needed or unsure
Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

evanweible-wf commented 5 years ago

QA +1

[x] Verified the test steps locally

Merging into master.