[lint] unsafe_html - Githubissues

Workiva / workiva_analysis_options

Workiva's shared Dart static analysis options

Other

3 stars 1 forks source link

[lint] unsafe_html #143

Open evanweible-wf opened 4 years ago

evanweible-wf commented 4 years ago

http://dart-lang.github.io/linter/lints/unsafe_html.html

Infractions should be rare
Having to explicitly ignore valid usages is a good practice, given the security concern
(As of Nov 15) Number of infractions at Workiva: 16

dustyholmes-wf commented 3 years ago

@evanweible-wf it looks like since your evaluation google has added several more reasons why this would be triggered to the list. They do not seem to provide any guidance on alternate solutions though. In trying to get 2.13 ready, I have found 6 new instances in DPC. https://github.com/dart-lang/linter/pull/1528#issuecomment-494001466 leads me to believe that this is a lint worth knowing about but that there aren't necessarily clear ways to address them. I wonder if we should still require it.

evanweible-wf commented 3 years ago

Yeah, that's a good point. Sounds like this would be better suited as a recommended lint and people can ignore individual instances where it's been evaluated and OK'd.