Closed kanjirz50 closed 4 years ago
Thaks PR !
I needed but I couldn't update SudachiPy side because of my own business and another research for these trouble.
Your modification is almost enough for recent my update to dartsclone
but I'm cocerning that your description is different from what we really reolved for what problem.
You wrote bellow but it's out of the point.
It seems like that dartsclone 0.6.0 doesn't support SudachiDict_core-20191030 (latest dictionary).
We have problem and resolution here https://sudachi-dev.slack.com/archives/CBCF278AC/p1575185307012400
https://github.com/WorksApplications/SudachiPy/issues/99
Could you wait a moment for me making PR ? It may be almost same code modification but I want to conclude these problems with correct information. I'd very glad to your mind to contribute to our community but this problem is already under resoving and just before summarizing :disappointed_relieved:
We should share what we are doing with using issues...
@kanjirz50 But I have a question ! Could you makeSudachipy 0.4.*
works with dartsclone 0.6.0
with SudachiDict_core-20190927.tar.gz
? If so it's out of my understanding...
@izziiyt Thanks for your reply!
Please don't worry about my PR. Sudachi is a great OSS, so I want to contribute as much as possible. I appreciate your swift PR #111 .
That slack thread shows the same error message. Sorry for I couldn't find out it on slack.
I also checked sudachipy 0.4.2
with dartsclone 0.6.0
with SudachiDict_core-20190927.tar.gz
, but it didn't work in my environment.
Python 3.6.9, Ubuntu 16.04, pip freeze
Cython==0.29.14
dartsclone==0.6
sortedcontainers==2.1.0
SudachiDict-core==20190927
SudachiPy==0.4.2
If I update dartsclone 0.7.0
, it works..
It seems like that
dartsclone 0.6.0
doesn't supportSudachiDict_core-20191030
(latest dictionary).Here is a traceback.
'dartsclone 0.7' can use 'SudachiDict-core 20191030'. I updated dartsclone and SudachiDict-core version in
requirements.txt
andsetup.py
.