search

WorksApplications / sudachi.rs

Sudachi in Rust 🦀 and new generation of SudachiPy
Apache License 2.0
318 stars 34 forks source link

aarch64 Linux Wheels #220

Open polm opened 2 years ago

polm commented 2 years ago

I noticed you don't have wheels for aarch64 for Linux. Do you have any plans to release such wheels?

Github Actions supports this architecture, so it looks like you can probably just make a small change to the current wheel building actions.

eiennohito commented 2 years ago

Since the last version, we do universal2 builds for macOS which work both on aarch64 and x64 at the same time, which is better in my opinion. The bad thing is Github Actions does not support managed runners yet, only self-hosted ones and we neither have infrastructure nor manpower to host the runner ourselves. So while there are build, they are not tested on aarch64 at all and may stop working at any time. I run tests on my M1 Macbook from time to time, but until there is a hosted option for Github Actions runner, it will not move futher.

cf:

  1. https://github.com/github/roadmap/issues/528
  2. https://github.com/actions/runner-images/issues/2187
polm commented 2 years ago

Thanks for the clarification, but I am asking specifically about Linux aarch64, not OSX. I know the managed OSX runners on Github Actions still aren't fully usable with Python, but with Linux they should work - I build aarch64 wheels for mecab-python3 and fugashi. For example here is the action for aarch64 wheels for fugashi.

I don't think Linux aarch64 is that common, but it does include Raspberry Pi users, and potentially people running Linux (or Docker) on M1 machines.

eiennohito commented 2 years ago

Ah, Linux aarch64. I completely missed Linux in your first post, apologies.

Pull request is welcome! Current linux build does PGO which is good for binary builds, but it probably should work on aarch64 as well with minor modifications.

Rhtyme commented 8 months ago

In my case, I just installed rust :

curl --proto '=https' --tlsv1.3 https://sh.rustup.rs -sSf | sh and then did :

source $HOME/.cargo/env by following this tutorial.

Then I just did:

pip install --upgrade 'sudachipy>=0.6.8'

as it is instructed, and installed successfully!