search

World-Wide-JUGs / GlobalWWJugs

World Wide JUGs - List of Java User Groups around the world
https://world-wide-jugs.github.io/GlobalWWJugs/
GNU General Public License v3.0
17 stars 48 forks source link

Add favicon #26

Closed ziebamarcin closed 3 years ago

ziebamarcin commented 3 years ago

I found out that there is not favicon on page. Just copying duke from images dir to root dir solved the problem

ziebamarcin commented 3 years ago

Hi @icougil

That is really interesting because I tried to verify that and after opening, I have seen sth like "Cannot show binary file" and after refreshing github I also see "Empty file".

I think it is some strange github error. Can you verify that you can view file using "dots" menu? image

When I use it I can see that file has content. I've also tested it locally, by running jekyll and favicon was loaded correctly.

icougil commented 3 years ago

Ook! Yes it has to be an error from github then. I will approve your PR, at the end I was able to see the file 😉