search

WorldBrain / Memex

Browser extension to curate, annotate, and discuss the most valuable content and ideas on the web. As individuals, teams and communities.
https://worldbrain.io
4.42k stars 337 forks source link

CPU usage by Memex extension gone wild in Firefox Mac OS X #1011

Open autonome opened 4 years ago

autonome commented 4 years ago

If reporting a bug:

  1. Can you describe the problem and bug in more detail?

The CPU usage is too high. Should be throttling/debouncing/etc a lot more.

  1. How can we replicate the issue?

I'm not sure, depends on cause. I have a lot of bookmarks and history, so maybe related?

Always seems to happen after browser startup. Sometimes seems to happen at other times also, but I haven't correlated it with a specific action.

  1. Expected behavior (i.e. solution)

Memex should not be causing extended CPU spikes.

  1. Error stack (from extension crash page)

NA

  1. Other comments
blackforestboi commented 4 years ago

Agreed that it shouldn't take that much CPU. We are working on some big improvements to the resources usage.

Do you have a lot of open tabs when the browser starts? Did you already import all your history and bookmarks?

blackforestboi commented 4 years ago

@autonome did you experience this again at some point?

autonome commented 4 years ago

I disabled the extension. I probably should be classified as "extreme" user

On Fri, Jun 12, 2020 at 6:50 AM Oliver Sauter notifications@github.com wrote:

@autonome https://github.com/autonome did you experience this again at some point?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/WorldBrain/Memex/issues/1011#issuecomment-643207648, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMHN3JQBQWFHF5YDSZTU3RWIB6TANCNFSM4MSC4JOQ .

blackforestboi commented 4 years ago

and epically large bookmarks and history

Can you put a number on that one?

However, it's likely also that the addon's architecture is doing too much work at once instead of chunking/batching across long periods to reduce max work level

Yeah very likely. We've done a lot of work in the latest release so it may have improved the situation for you. Would be interesting to know if that's the case. The browser startup we still need to optimise better - should already be a lot better though.