search

WorldBrain / Memex

Browser extension to curate, annotate, and discuss the most valuable content and ideas on the web. As individuals, teams and communities.
https://worldbrain.io
4.43k stars 339 forks source link

When text selection>=2, only the first selection gets memex-highlight inserted #1140

Open aaaawwWWWwwwwWWW opened 3 years ago

aaaawwWWWwwwwWWW commented 3 years ago

  1. Can you describe the problem and bug in more detail? Multiple text selection highlighting (selections>=2) only visually highlights the first selection (memex-highlight class is inserted only to the first text selection), although it stores all of them as it should.

  2. How can we replicate the issue?

https://user-images.githubusercontent.com/73749744/103104179-757ef480-4604-11eb-895c-d1dc652fe5ba.mp4

  1. Expected behavior (i.e. solution) Insert memex-highlight class to all selected text regions, visually highlighting them.
zoncrd commented 3 years ago

I was able to reproduce the described issue on Firefox and only on this because it seems to be the only mainstream browser to support multiple selection ranges.