WorldBrain / Memex

Browser extension to curate, annotate, and discuss the most valuable content and ideas on the web. As individuals, teams and communities.
https://worldbrain.io
4.43k stars 339 forks source link

In dark mode websites, highlighted text is basically unreadable (!) #1227

Open Elaws opened 2 years ago

Elaws commented 2 years ago

Windows 10 - 21H2 Firefox 96.0.1

Description :

On dark mode, text highlighted with Memex is basically unreadable, which kind of defeats the purpose of an highlighter ! See the picture below.

Has Memex succesfully been tested with dark mode websites ? Is there any way to change highlight color, to provide better contrast with dark mode websites ?

Thank you !


EXAMPLE :

firefox_bsR6nBpXBq

davidpomerenke commented 2 years ago

I'm using the Dark Reader addon for Firefox -- I think it is the most common such addon and also "recommended" in the Firefox addon store --, and the result is similar.

grafik

When hovering over the highlight with the mouse, it's a bit better:

grafik

mmahmoudian commented 2 years ago

I came here to mention the same thing. I think this can be avoided if the text color is forced to black. Although I should say I really don't like a cold pale color (#d4e8ff) that you currently use as it does not show highlighting or importance of the marked text. I prefer a light orange or yellow.

Elaws commented 2 years ago

Has there been some acknowledgment of this issue since it was reported a month ago ?

Thanks !

CheariX commented 2 years ago

This Post helped me to adjust the settings in DarkReader.

Just place the CSS Code in DarkReader's Settings -> Devtools on top like this:

*

INVERT

// Leave as it is

CSS
._2ENyfEDXjYwJlp5AGrY3Cx.cSQDsBP55bHAsqD8CQiXo{
background: #7c6a33 !important;
}
._2ENyfEDXjYwJlp5AGrY3Cx {
 background: #568f46 !important;
}