search

WorldBrain / Memex

Browser extension to curate, annotate, and discuss the most valuable content and ideas on the web. As individuals, teams and communities.
https://worldbrain.io
4.43k stars 339 forks source link

Memex manipulates DOM again. #594

Closed blackforestboi closed 5 years ago

blackforestboi commented 6 years ago

If reporting a bug:

  1. Can you describe the problem and bug in more detail? On this page, there is a login field shown when Memex is not installed. When Memex is installed it seems as if the background image is pulled forward on the z-axis. However I can't find any setting to it. As you'll see in the inspector, you can remove the background(s) and will see the login screen again.

  2. How can we replicate the issue? 1) Open the page. 2) se no login screen 3) disable extension & open page again 4) see login screen

  3. Expected behavior (i.e. solution) Login screen shown

  4. Error stack (from extension crash page) No errors that are only there when extension is enabled.

  5. Other comments The page itself seems to be a source of problems too, as with other dom-manipulating extensions, like Lastpass, there are also glitches.

manveru commented 6 years ago

Also found that Memex breaks certain Elm applications like https://package.elm-lang.org/ where Elm expects to have full control over the <body>.

blackforestboi commented 5 years ago

I did some more research on this and it seems as the tooltip, even though not yet displayed, is inserting a div that interferes with the rest of the page. The page mentioned in the OP looks normal if the div has a display: none set. Maybe we can solve this by just enabling that CSS setting by default and only when people highlight stuff the display setting is changed.

Unfortunately, the same trick does not work with the Elm page :(

screen shot 2018-11-28 at 18 25 03
cipri-tom commented 5 years ago

I think Memex has just been updated to v1.1.5 and all of my pages started looking bigger.

Example:

Screenshot 2019-05-02 at 14 38 19

from the page https://stackoverflow.com/questions/41820933/

Here is what it looks like when I disable the Memex extension and reload the page:

Screenshot 2019-05-02 at 14 39 41

Almost all fonts, in all pages are bigger. Sometimes to such an extent that it makes the websites unusable :(

Firefox v66.0.3, macOS Mojave.

blackforestboi commented 5 years ago

Sorry, fixed with latest update 1.1.6 just now!