search

WorldBrain / Memex

Browser extension to curate, annotate, and discuss the most valuable content and ideas on the web. As individuals, teams and communities.
https://worldbrain.io
4.39k stars 335 forks source link

DuckDuckGo search results dark mode #906

Open viktomas opened 4 years ago

viktomas commented 4 years ago

If reporting a bug:

  1. Can you describe the problem and bug in more detail? DuckDuck go can be switched to dark mode, the memex search results widget doesn't play nicely with that.

  2. How can we replicate the issue?

    Screenshot 2019-12-02 at 9 09 56 AM

  3. Expected behavior (i.e. solution) The text colour will have better contrast with the dark mode DuckDuckGo

  4. Other comments I like the memex idea. I'm surprised that there is so few issues marked as a good first issues for contributors. You might want to ask for more help :)

blackforestboi commented 4 years ago

Thanks for the note @viktomas.

Unfortunately this has to wait a bit because our core team does not have the time right now to fix this. We could however spend the time to review a high quality PR by someone and get it in.

Vexatos commented 4 years ago

As a pointer, all dark themes in duckduckgo have the dark-bg class in their <html> tag. Using that, it should be relatively easy to use different colours in the CSS files when that class is present.