search

WorldBrain / storex

Storex Core - A modular and portable database abstraction ecosystem for JavaScript
MIT License
150 stars 8 forks source link

Better define main CRUD ops' return types #9

Open poltak opened 5 years ago

poltak commented 5 years ago

Based on what we discussed this a while back on slack: https://worldbrain.slack.com/archives/CBLN20LCU/p1545279785004100

I think it's probably better to decide on these return types early on. Not sure exactly about the choices; what do you think?

ShishKabab commented 5 years ago

Sorry for my late reply here. Good to decide on the return types. Everything OK for adding the separate PK field for the createObject operation. However, I'd like the count value of the update and delete operations to be an option explicitly passed in, with a BackendFeatures entry, because it could be not every back-end supports that natively, and thus may have to execute an extra query for that.