WorldCereal / worldcereal-classification

This repository contains the classification module of the WorldCereal system.
https://esa-worldcereal.org/
MIT License
36 stars 4 forks source link

Additional argument 'settings' in `worldcereal_preprocessed_inputs` #87

Open VincentVerelst opened 4 months ago

VincentVerelst commented 4 months ago

would be nice to have an additional optional argument "settings" for the worldcereal_preprocessed_inputs_gfmap function, specifying:

kvantricht commented 3 months ago

@GriffinBabe for now I assigned this to you but this may need to change. If you can give this a thought that would be great.

GriffinBabe commented 3 months ago

I would extend the logic of the parameters we created for the CropLand workflow

https://github.com/WorldCereal/worldcereal-classification/blob/main/src/worldcereal/job.py#L59

Here we have classes CropLandParameters and CropTypeParameters, we could define an additional class WorldCerealInputParameters or similar that will also use pydantic for type consistency/checking

Then all the parameter objects that use inputs (CropLandParameters, CropTypeParameters) would have a field instance of that class.

jdegerickx commented 3 days ago

@kvantricht , you think this is still needed?