WorldHealthOrganization / ddcc

DDCC
Other
23 stars 20 forks source link

New Profile for DDCCDocumentSigned #68

Open mickohanlon23 opened 2 years ago

mickohanlon23 commented 2 years ago

According to the Expected Actions of a Submit Health Event transaction:

"The DDCC:VS Generation Service...shall generate and sign a DDCC Document"

However, since a DDCC Document's Bundle.signature is not required, any validation using this profile will not check for the existence of a signature, which seems to be an integral part of the Submit Health Event response.

There are clearly reasons why signature cannot be required (i.e. the DDCCDocument cannot have a signature before it is signed). Therefore we propose creating a new DDCCDocumentSigned profile that would allow for the validation of a signed DDCC Document, as is expected by the response of a Submit Health Event transaction.

litlfred commented 2 years ago

+1

From: mickohanlon23 @.> Sent: Thursday, December 9, 2021 1:39 PM To: WorldHealthOrganization/ddcc @.> Cc: Subscribed @.***> Subject: [WorldHealthOrganization/ddcc] New Profile for DDCCDocumentSigned (Issue #68)

According to the Expected Actions of a Submit Health Event transaction https://worldhealthorganization.github.io/ddcc/transactions.html#submit-health-event-expected-actions :

"The DDCC:VS Generation Service...shall generate and sign a DDCC Document"

However, since a DDCC Document https://worldhealthorganization.github.io/ddcc/StructureDefinition-DDCCDocument.html 's Bundle.signature is not required, any validation using this profile will not check for the existence of a signature, which seems to be an integral part of the Submit Health Event response.

There are clearly reasons why signature cannot be required (i.e. the DDCCDocument cannot have a signature before it is signed). Therefore we propose creating a new DDCCDocumentSigned profile that would allow for the validation of a signed DDCC Document, as is expected by the response of a Submit Health Event transaction.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/WorldHealthOrganization/ddcc/issues/68 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFBVYVAVK5IQ3S4AVG3L6TUQDZVZANCNFSM5JXFZFHA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub . https://github.com/notifications/beacon/AAFBVYWFQBJAAY3OCYPCKDDUQDZVZA5CNFSM5JXFZFHKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4QBAVLNA.gif