search

WorldHistoricalGazetteer / whg3

Version 3 beta
BSD 3-Clause "New" or "Revised" License
4 stars 4 forks source link

Upload file with aat_types fails test for fclasses #270

Closed kgeographer closed 3 months ago

kgeographer commented 3 months ago

The current validation functions, validate_delim() and validate_lpf() have a strict requirement for fclasses (as per latest LPF and LP-TSV spec) but really should require each row have at least one of fclasses or aat_types. Need to confirm that a valid aat_type (one of WHG's 170 supported values) will automatically generate an fclasses value on insert.

kgeographer commented 3 months ago

Refactored both validate_delim() and validate_lpf() to reflect newly re-stated requirement that EITHER fclasses or aat_types (type.identifier in LPF) be present, not strictly fclasses. A file needs one or both columns and each row needs a value in at least one of them