Add new nodes and exemplars

WorldModelers / Ontologies

Ontologies for the World Modelers system

Creative Commons Attribution 4.0 International

6 stars 11 forks source link

Add new nodes and exemplars #115

Closed zupon closed 3 years ago

zupon commented 3 years ago

Adds a bunch of new exemplars to existing nodes, as well as some new nodes to the ontology, based on #109 and #110.

BeckySharp commented 3 years ago

@zupon I approve overall but left some comments, please address them before merging

MihaiSurdeanu commented 3 years ago

@zupon: these look great in general! I left a few comments. @chanys: what do you think?

zupon commented 3 years ago

@MihaiSurdeanu Did you post your comments here on this PR? I can't seem to find them.

MihaiSurdeanu commented 3 years ago

Scroll up, and you'll see them attached to the ontology changes.

zupon commented 3 years ago

Sorry to revisit this so late, but I don't see any comments from you here in the Conversation tab nor in-line in the Files changed tab. I only see Becky's comments here.

MihaiSurdeanu commented 3 years ago

My comments are part of the review. I see them simply by scrolling up in this thread. In any case, here they are as a screenshot:

zupon commented 3 years ago

@MihaiSurdeanu Thanks for the screenshot! I definitely don't see them in the thread.

I got rid of the questionable exemplars and moved discriminate out of process/communicate and put it under process/conflict, which also has nodes for abuse and exploit, so it might be a better fit there.

MihaiSurdeanu commented 3 years ago

Thanks!

@BeckySharp: ok to merge?

zupon commented 3 years ago

Closes #109 Closes #110

zupon commented 3 years ago

Closes #104 Closes #105

zupon commented 3 years ago

Closes #111 Closes #112 Closes #113

zupon commented 3 years ago

Closes #101 Closes #102

zupon commented 3 years ago

@BeckySharp I think this is ready to merge. What do you think?

BeckySharp commented 3 years ago

yes thanks!