Closed zupon closed 3 years ago
@zupon I approve overall but left some comments, please address them before merging
@zupon: these look great in general! I left a few comments. @chanys: what do you think?
@MihaiSurdeanu Did you post your comments here on this PR? I can't seem to find them.
Scroll up, and you'll see them attached to the ontology changes.
Sorry to revisit this so late, but I don't see any comments from you here in the Conversation
tab nor in-line in the Files changed
tab. I only see Becky's comments here.
My comments are part of the review. I see them simply by scrolling up in this thread. In any case, here they are as a screenshot:
@MihaiSurdeanu Thanks for the screenshot! I definitely don't see them in the thread.
I got rid of the questionable exemplars and moved discriminate
out of process/communicate
and put it under process/conflict
, which also has nodes for abuse
and exploit
, so it might be a better fit there.
Thanks!
@BeckySharp: ok to merge?
Closes #109 Closes #110
Closes #104 Closes #105
Closes #111 Closes #112 Closes #113
Closes #101 Closes #102
@BeckySharp I think this is ready to merge. What do you think?
yes thanks!
Adds a bunch of new exemplars to existing nodes, as well as some new nodes to the ontology, based on #109 and #110.