Closed zupon closed 3 years ago
@spilioeve hopefully you can review too to make sure this doesn’t break anything for you
As soon as this gets merged, I can start regrounding.
Hi all,
I am a bit confused with the semantic type being "event" for all nodes by default. This is not correct and will cause issues with Sofia; all these words are treated as potential "causes" or "effects". Sofia won't break, but it will produce a lot of wrong causal relations.
Do we have a plan to automatically or manually tag each new node as an "event" or "entity"? In the case of ontology extension the new nodes may be problematic (minor impact), but if we are building an ontology from scratch this would be a major problem; a lot of trash will be generated. For now I can go and manually correct the fields that are wrong, after the changes are made in the branch.
On Fri, May 28, 2021 at 11:08 AM Keith Alcock @.***> wrote:
As soon as this gets merged, I can start regrounding.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/WorldModelers/Ontologies/pull/126#issuecomment-850485477, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGMZ3HRCX4STZ5GJJMAQUNTTP6WWXANCNFSM45VJTMEQ .
Hi all, I am a bit confused with the semantic type being "event" for all nodes by default. This is not correct and will cause issues with Sofia; all these words are treated as potential "causes" or "effects". Sofia won't break, but it will produce a lot of wrong causal relations. Do we have a plan to automatically or manually tag each new node as an "event" or "entity"? In the case of ontology extension the new nodes may be problematic (minor impact), but if we are building an ontology from scratch this would be a major problem; a lot of trash will be generated. For now I can go and manually correct the fields that are wrong, after the changes are made in the branch. …
they are event bc we didn’t know if you wanted them or not, but that’s why we asked you to edit them. i think there are only like ~30 so manually doing it won’t be too bad, and you should prob do it nowish and just push to this branch before the merge. the tool has the ability to set it, so in the future ppl can decide what type they should be
Okay I reviewed it and changed the semantic type in the new fields. Please lmk if you can view the changes
On Fri, May 28, 2021 at 1:35 PM Becky Sharp @.***> wrote:
Hi all, I am a bit confused with the semantic type being "event" for all nodes by default. This is not correct and will cause issues with Sofia; all these words are treated as potential "causes" or "effects". Sofia won't break, but it will produce a lot of wrong causal relations. Do we have a plan to automatically or manually tag each new node as an "event" or "entity"? In the case of ontology extension the new nodes may be problematic (minor impact), but if we are building an ontology from scratch this would be a major problem; a lot of trash will be generated. For now I can go and manually correct the fields that are wrong, after the changes are made in the branch. … <#m2147622661029453915>
they are event bc we didn’t know if you wanted them or not, but that’s why we asked you to edit them. i think there are only like ~30 so manually doing it won’t be too bad, and you should prob do it nowish and just push to this branch before the merge. the tool has the ability to set it, so in the future ppl can decide what type they should be
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/WorldModelers/Ontologies/pull/126#issuecomment-850568293, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGMZ3HSOVA6EFMBA4IBQFQ3TP7H5PANCNFSM45VJTMEQ .
I see the changes, but can they be turned into a PR against this branch?
Nevermind. You are a step ahead of me.
ok @kwalcock have at it!!! thanks all!!!
Adds new nodes from today's ontology extension exercise. All new nodes are currently placed under
wm/concept/clusters/
. There are a few that might potentially be better underprocess
, including:There were two different occurrences of
environmental_degredation
as new nodes. One of them only hadenvironmental_impacts
as an example, so I just renamed that node toenvironmental_impacts
. I could also just move that example into the other node.By default, the
semantic type
field in the UI was set toevent
. I changed the field toevent
for the new nodes (only), but these need to be checked @spilioeve