Open astrofrog opened 6 years ago
Can you please describe the behavior? Are the sizes screen sized, but wrong? Or are they fixed to scale?
@astrojonathan - the easiest way to show you is to show the reference images we use for rendering tests - on Windows it seems that things are now consistent with the way they were before, and look like:
On Linux and MacOS X, the top circle looks different:
The top circle was created with a radius of 5 and with skyRelative
set to false
. I'm not sure why the current Windows rendering (which was run in our continuous integration) looks like the old pre-webGL rendering (does the SDK fall back to a non-WebGL version if OpenGL is not available?), but at least it gives you an idea of how large the circle used to be. The MacOS X/Linux rendering shows that the circle is now much larger.
Interestingly you can also see differences in the line widths (again the top image is the 'correct' version)
Circles with a radius given in pixels are now larger in WebGL than they were before. It would be nice to make them consistent if possible. The reference images updated in https://github.com/WorldWideTelescope/pywwt/pull/104 will need to be updated again (at least the
step5
ones) once this is fixed.