WorldWideTelescope / toasty

Break large images into "tile pyramids", with a focus on the all-sky TOAST format.
https://toasty.readthedocs.io/
MIT License
0 stars 4 forks source link

add tile-allsky --projection=plate-carree-panorama #55

Closed astrodavid10 closed 3 years ago

astrodavid10 commented 3 years ago

This adds a panorama option to the --projection argument in tile-allsky. It is the same projection as plate-carree but writes the dataset type as panorama, saving a couple steps. I'm not sure if this is the most efficient approach but it worked in my testing.

codecov[bot] commented 3 years ago

Codecov Report

Merging #55 (63761eb) into master (d667e3e) will decrease coverage by 0.11%. The diff coverage is 37.50%.

:exclamation: Current head 63761eb differs from pull request most recent head b83069c. Consider uploading reports for the commit b83069c to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   73.51%   73.39%   -0.12%     
==========================================
  Files          21       21              
  Lines        2632     2639       +7     
==========================================
+ Hits         1935     1937       +2     
- Misses        697      702       +5     
Impacted Files Coverage Δ
toasty/cli.py 88.01% <20.00%> (-1.61%) :arrow_down:
toasty/builder.py 88.18% <66.66%> (-0.62%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d667e3e...b83069c. Read the comment docs.

pkgw commented 3 years ago

Hi David — Thanks, this looks perfect! I especially appreciate the update to the docs as well. In a perfect world it would be nice to also add some relevant tests to the test suite, but it would take a lot of work to set that up and the changes here are quite straightforward, so I'm completely comfortable skipping that here.

pkgw commented 3 years ago

I'll issue a 0.9.0 release to get this new feature formally published.