Only re-assign RaUnits if in SpreadSheetLayer.LoadFromString when not updating

[astrofrog]

I ran into an issue when using LoadFromString for spreadsheet layers to update the data - in this case, the code sometimes reset the RA units. However I believe this should only happen if isUpdate is False, as for guessing the header assignments.

I'm not set up to compile/use the C# code locally, so this change is untested (but I made the same change in the generated JS and it worked)

[pkgw]

I just wanted to mention — I've prototyped a Vagrant VM setup for building the C# code, so that people with Linux and macOS boxes can work with the code too. It's a bit clunky right now, but I'm happy to share if you're interested! It would probably be good to get another set of eyes on it.

[pkgw]

This looks reasonable to me, FWIW. @astrojonathan do you concur?

[astrojonathan]

Is that happening in Guess Header Assignments? That probably should only trigger during the initial push, not on updates. I will look at this tonight and compare to the desktop version. Jonathan

On Tue, Nov 20, 2018 at 9:16 AM Peter Williams notifications@github.com wrote:

This looks reasonable to me, FWIW. @astrojonathan https://github.com/astrojonathan do you concur?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/WorldWideTelescope/wwt-web-client/pull/183#issuecomment-440354826, or mute the thread https://github.com/notifications/unsubscribe-auth/AJOEjzvjJ4VNyxejVpHlhGRcKnB26b-8ks5uxDjcgaJpZM4Yrhin .

[astrofrog]

It happens after the header guessing, but unlike the header guessing, it happened unconditionally on whether this was an update or not. This PR changes is it so that it happens after header guessing, and only if header guessing is done.