search

WorldWideTelescope / wwt-web-client

The WorldWide Telescope web client lets you explore the universe in your browser.
https://worldwidetelescope.org/webclient/
MIT License
105 stars 35 forks source link

Fix xyzScale if we are in astronomical mode #213

Closed astrofrog closed 5 years ago

astrofrog commented 5 years ago

This fixes an asymmetry that if we are in astronomical mode, we should have the same behavior for cartesian and spherical coordinates for scaling the coordinates, otherwise the markers appear at larger distances from the sun than they should.

astrofrog commented 5 years ago

The CI is broken due to https://github.com/WorldWideTelescope/wwt-web-client/issues/215

pkgw commented 5 years ago

Pushed Ron's fix, hopefully fixing CI.

astrofrog commented 5 years ago

@pkgw - thanks, I rebased to get rid of the merge commit.

astrofrog commented 5 years ago

Just confirming this fixes cartesian layers when the reference frame is Sky and astronomical=true and removes the need for a workaround in PyWWT.

astrojonathan commented 5 years ago

I will have to make a build of the merge and have Ron Deploy it.