Try and fix scaling by mean radius

WorldWideTelescope / wwt-web-client

The WorldWide Telescope web client lets you explore the universe in your browser.

https://worldwidetelescope.org/webclient/

MIT License

105 stars 35 forks source link

Try and fix scaling by mean radius #214

Closed astrofrog closed 5 years ago

astrofrog commented 5 years ago

As described in https://github.com/WorldWideTelescope/wwt-web-client/issues/189, for spreadsheet layers the positions are currently not scaled by the right value if not centered on the earth. It looks like there is actual code that was commented out that appears to do the right thing, so just testing if this works (opening the PR to build the JS SDK easily).

astrofrog commented 5 years ago

The CI is broken due to https://github.com/WorldWideTelescope/wwt-web-client/issues/215

pkgw commented 5 years ago

Pushed Ron's fix, hopefully that unsticks CI.

astrofrog commented 5 years ago

This works nicely for me and fixes #189. Interestingly this line is not commented out in the desktop client code:

https://github.com/WorldWideTelescope/wwt-windows-client/blob/e8bc0b5f0587fa31d077f24427dc9ad10a5b3e17/WWTExplorer3d/SpreadSheetLayer.cs#L1226

suggesting that it is correct.