search

WorldWideTelescope / wwt-web-client

The WorldWide Telescope web client lets you explore the universe in your browser.
https://worldwidetelescope.org/webclient/
MIT License
105 stars 35 forks source link

Make web client able to read uncompressed data layers #251

Closed astrofrog closed 5 years ago

astrofrog commented 5 years ago

The web client currently writes out uncompressed data layers but expects them to be compressed when reading them in. This PR adjusts the getStringFromGzipBlob function to return strings as-is if they fail the zlib/gzip header test.

For now this just adds a regression test, and a fix will follow.

pkgw commented 5 years ago

@astrofrog Don't think you actually committed/pushed the part that fixes getStringFromGzipBlob?

edit: Oh I see that's intentional :-)

astrofrog commented 5 years ago

Indeed I like to push up regression tests first to make sure the CI catches it :) I've now pushed up the fix itself.