search

WorldWideTelescope / wwt-windows-client

WorldWide Telescope Windows Application
Other
179 stars 55 forks source link

Spherical Mirror Warp Regression 6.0.4.1 #128

Closed astrodavid closed 5 years ago

astrodavid commented 5 years ago

In version 6.0.4.1, the spherical mirror warps, 16x9 or 4x3, are zoomed in on the usual view which distorts the warp.

astrodavid commented 5 years ago

This is noticeable in fulldome mode, but may apply to flat screen mode as well. I will test with VR next week.

astrodavid commented 5 years ago

zoomedsphericalwarp Fullscreen view

pkgw commented 5 years ago

Thanks. This is basically just my ignorance, but can you explain to me what you mean when you write that the views are "zoomed in on the usual view"? Thanks.

astrodavid commented 5 years ago

Of the three issues I just opened, this is by far the most pressing as I will not be able to use the release in a planetarium mode if this isn't fixed :/ I'll post tomorrow a picture of what it should look like (when I get back to my other computer), but basically we are only viewing perhaps 80% of the usual view, it is cropped on the sides and bottom. All of the Az lines in the image should bend down to the ground.

pkgw commented 5 years ago

Gotcha, and thanks for the prioritization info.

astrodavid commented 5 years ago

No worries! Here is the proper warp from a previous build (5.5.20.1)

16x9 correct warp grid

astrodavid commented 5 years ago

Fixed.

pkgw commented 5 years ago

Code change, or did the problem not end up being on the WWT side?

astrodavid commented 5 years ago

Slight code change: https://github.com/WorldWideTelescope/wwt-windows-client/commit/11a53e1c4f9e4b0f5633cf9a3f94f738ca681df6

pkgw commented 5 years ago

Great, thanks — it's helpful to cross-link the issues and the code (exactly like you just did!) for posterity.

astrojonathan commented 5 years ago

The issue number is usually included in the PR description, but I missed that.,