search

WorldWideTelescope / wwt-windows-client

WorldWide Telescope Windows Application
Other
179 stars 55 forks source link

Change installation location #176

Closed Carifio24 closed 2 years ago

Carifio24 commented 2 years ago

Just a simple PR to get my feet wet with the Windows client. This modifies the installation location of the Windows client from Microsoft Research\Microsoft WorldWide Telescope to American Astronomical Society\AAS WorldWide Telescope.

pkgw commented 2 years ago

Closing and reopening to retry the CI. The builder machine should have woken up by now, hopefully.

pkgw commented 2 years ago

Yay, it worked! And the build artifacts include things that look like the right kinds of executables.

pkgw commented 2 years ago

@Carifio24 Please play around with the artifacts generated by the CI process, and let me know if/when you can confirm that the installer seems to be working correctly for you? I'll also try an installation on the Surface tablet I have. We should expect warnings about unsigned code since this is a PR.

Carifio24 commented 2 years ago

@pkgw The installer from the CI is working correctly for me - the installation location is correct, and the client itself seems to be running fine.

pkgw commented 2 years ago

I agree! Now I'll merge and we can check on the status of the code-signing for updates to the master branch.

pkgw commented 2 years ago

Well, the initial CI run on the master merge failed with some odd error while building the installer, but it worked when I retried, and now we have some artifacts that ought to be properly signed!

pkgw commented 2 years ago

I checked out the signed artifacts and they seem to be OK. I still get some warnings about unrecognized software when launching the installer from a download, but that seems to be a separate layer of protection.

astrojonathan commented 2 years ago

We need to make sure that we test WWTRemote and make sure that we don't break planetarium and KIOSK installs that might assume install location. Just double-check there are no side effects of this.

pkgw commented 2 years ago

Yeah, we'll test as best we can, and also emphasize the change in the release notes. In general we'll make it clear that people with production deployments shouldn't update them without careful and thorough testing.