search

WorldWideTelescope / wwt-windows-client

WorldWide Telescope Windows Application
Other
179 stars 55 forks source link

VOTable radius/distance/etc columns not working #178

Open pkgw opened 2 years ago

pkgw commented 2 years ago

As reported by @astrodavid10: if you have a VOTable with 3D data, the distance axis doesn't seem to be working. Everything shows up at R = 1 AU.

Here's a gzipped WWTL sample file that demonstrates the problem: exoplanets_vo_nov_2021.wwtl.gz

a VO table of exoplanets that simply extends to a shell in the SS mode in the Windows client.

Carifio24 commented 2 years ago

So I've identified where in the code for VOTable layers this is, and I think I have it working, but it's a bit difficult to test since I don't know what the layer in this example should look like. @pkgw @astrodavid10 do either of you know what this layer should look like? The screenshots below are how I've got it displaying now. I'm a bit concerned about the first screenshot - I don't know a lot about the distribution of known exoplanet locations, but it seemed odd to me that some would be so far off of the galactic plane.

ExoplanetsSS1 ExoplanetsSS2

astrodavid10 commented 2 years ago

@Carifio24 Hmmm, I'm not seeing the Kepler cone like I'd expect:

exo_mw_d7_3 exo_mw_d7

Carifio24 commented 2 years ago

@astrodavid10 Thanks for the screenshots, and the mention of the Kepler cone - I found what I think was the issue and am now getting the images below from this layer. Looks like the Kepler cone on the left and exoplanets found via microlensing going to the right. ExoplanetsSS3 ExoplanetsSS4

astrodavid10 commented 2 years ago

@Carifio24 Looking much better, thanks!

Carifio24 commented 2 years ago

@astrodavid10 One more question about this layer - what units should be used for the distance? The Layer tag on line 13 of the WWTL file has AltUnit="LightYears" and AltColumn="77". However, column 77 (sy_dist, on line 99 of the WWTL file) has the units as parsecs. The VoTableLayer picks up the AltUnit from the layer tag and uses light years as the distance unit when displaying the layer.

astrodavid10 commented 2 years ago

PS_2021.11.30_19.50.39.xml.zip @Carifio24 Hmmm, should be parsecs. The initial votable, zipped and attached, can be added as a votable from Explore -> Open -> VOTable and this does not auto recognize the distance parameter. When sy_dist is selected as the distance parameter, the units cannot be specified and so I guess it is not interpreting them correctly.

Carifio24 commented 2 years ago

@astrodavid10 Hmm, yeah, it seems that the VOTable viewer just assumes that the distance unit is light years. It looks like the VoTable already stores the unit (as a string) for each column, so it should hopefully be a quick fix.

astrodavid10 commented 2 years ago

@Carifio24 @pkgw Initial testing looks very good to me, thanks! As I pan around the exoplanet data while zoomed out, individual points end up fading (well, it looks like clipping and it is abrupt) in and out. Is there any way to control this such that the whole dataset can be viewed without any part being removed?

See also #183 for much larger clipping instances.

pkgw commented 2 years ago

@astrodavid10 This sounds like it could be the "far side visible" setting that I mentioned in the other issue. Do you happen to know how to control that setting in the UI? I think there's almost definitely a way, but I only know how to get at it from Python.

astrodavid10 commented 2 years ago

@pkgw That is what I figured, but as far as I can tell, there is no way to control that parameter through the VOTable UI. The properties button is not functional for VOTables and the VOTable Viewer doesn't have that setting.

pkgw commented 2 years ago

@astrodavid10 Thanks for reporting back. Either Jon or I can take a look through the source code to see if we're missing anything ... and also maybe try a hack to see if the setting is actually relevant anyway.