WorldWideTelescope / wwt-windows-client

WorldWide Telescope Windows Application
Other
179 stars 55 forks source link

VOTable distances #181

Closed Carifio24 closed 2 years ago

Carifio24 commented 2 years ago

This PR adds support for properly using the distance/altitude coordinate to VoTableLayer so that these layers will display at the correct position in the sky in Solar System mode - currently, VOTable layers display their points at a radius of 1 AU from the Sun (see #178). Since SpreadSheetLayers already support this, this is accomplished largely by mimicking the corresponding code inside that class. The relevant changes are in the PrepVertexBuffer method of VoTableLayer.

Related to this, when the distance column is set in the VOTableViewer, currently the unit is assumed to be light years. This PR changes that, using the unit for the relevant VoColumn (which is already parsed into the VoTable). To do this, I added a method in UiTools that grabs the appropriate AltUnits value based on the abbreviation given as the unit. Please let me know if there are any different/additional string representations that this should support.

One other thing worth mentioning:

pkgw commented 2 years ago

Awesome! @astrodavid10, do you know how to navigate to the Azure Pipelines artifacts to download an installer for the bleeding-edge version of the app that includes this fix?

astrodavid10 commented 2 years ago

@pkgw just figured it out! I'll test it out.