search

WorldWideTelescope / wwt-windows-client

WorldWide Telescope Windows Application
Other
179 stars 55 forks source link

Fix issue with auto-hiding tabs #182

Closed Carifio24 closed 2 years ago

Carifio24 commented 2 years ago

This PR fixes #111, which is that the Auto-Hide Tabs functionality does not if the LayerManager is closed via its close button.

The cause of the problem is the static variable LayerManager.InsideLayerManagerRect, which keeps track of whether or not the cursor position is within the layer manager. When the layer manager is closed, this variable no longer gets updated, so closing the layer manager using its close button (when InsideLayerManagerRect is true) means that the app continues to think that the mouse is over the layer manager. The fix in this PR is to set InsideLayerManagerRect = false when the layer manager is closed.

pkgw commented 2 years ago

Looks like a transient CI issue here — I restarted the job.