WorldWideTelescope / wwt-windows-client

WorldWide Telescope Windows Application
Other
179 stars 55 forks source link

Units in trajectory reference frames #185

Closed Carifio24 closed 2 years ago

Carifio24 commented 2 years ago

This PR adds support for different units in trajectory reference frames. There are a few different parts to this PR:

pkgw commented 2 years ago

CC #91

Carifio24 commented 2 years ago

I modified position to be a method that takes the altitude units as an input. This feels like a more natural way to ask for the position to me, and I don't expect there to be a significant difference between this and using the scale factor as the argument (the only time this gets called in a loop is when the orbit is refreshed after a unit change).

Note that there actually wasn't a serialization issue for this PR, since the trajectory positions X, Y, and Z were already stored in meters.