search

WorldWideTelescope / wwt-windows-client

WorldWide Telescope Windows Application
Other
179 stars 55 forks source link

Units in fixed spherical reference frames #186

Closed Carifio24 closed 2 years ago

Carifio24 commented 2 years ago

This PR adds support for specific the position of a fixed spherical reference frame in different units.

The code changes for this are, I think, relatively straightforward. Since this option doesn't apply to synodic reference frames, I've hidden the label and dropdown that I added for handling the units in the reference frame wizard when the frame in question is synodic.

pkgw commented 2 years ago

Your first commit here does something big to Setup1/datafiles.zip that's presumably unintended. Another opportunity to practice history rewriting ...

Carifio24 commented 2 years ago

I probably should've mentioned this in my original comment - the change to datafiles.zip was to modify localized text (line 21 in FrameWizardPosition.cs). I could only find one instance of text item 802 in the .cabinet file (pretty sure the language was Dutch). I don't 100% understand that file though, so it's possibly I missed some other language text.

pkgw commented 2 years ago

I think the GitHub diff report is saying that datafiles.zip shrank by 15 MB, which would imply that the rebuild changed a lot more than your text change?

Carifio24 commented 2 years ago

I did have to unzip -> change -> rezip that file, but I'm surprised it would make such a large difference.

For reference, the text that I wanted to change is the "Altitude (Meters)" label in the Position tab of the reference frame wizard - if we're allowing units other than meters, that label is now misleading. But as Jonathan pointed out elsewhere, the text in the code isn't what actually appears in the window, so I need to take another look at that particular change.

Carifio24 commented 2 years ago

It turns out that text item 763 is just Altitude, so I've just set the frame wizard to use this text when we have a fixed spherical frame, and the previous text for a synodic reference frame. No changes to the language text file required. To go along with this, I've also rewritten the history to omit the changes to Setup1/datafiles.zip.