search

WorldWideTelescope / wwt-windows-client

WorldWide Telescope Windows Application
Other
179 stars 55 forks source link

Typo fixes #188

Closed Carifio24 closed 2 years ago

Carifio24 commented 2 years ago

As a last item to round off this set of Windows client updates, this PR corrects a few typos that I noticed as I was working on some other fixes. This is by no means exhaustive - just a few things that happened to catch my eye.

astrojonathan commented 2 years ago

The text in the code IS NEVER displayed at runtime IRL, the text in the language file used to display all these fields and is where all spelling and typo fixes should be done. Fixing the text in the file will only show up when no language file is present, and won't impact end users. So if the language file has typos, it should be fixed there. Also some code typos to variable names, etc. are serialized to XML, so fixing them may cause backward compatibility and network sync issues, so be careful with fixing misspellings or renaming serialized field names. With millions of installed clients and some running big domes, we don't want to break customer installations to make the code a tiny bit prettier.

Carifio24 commented 2 years ago

Good point - currently, only the changes to 3dWIndow.cs are visible in the client itself. I'll look into modifying the language files for the other typos. I avoided changing any variable names lest that break anything - all of these typo fixes are restricted to modifying the content of strings.

Carifio24 commented 2 years ago

I've amended this PR to only include the two typo fixes that are visible (in 3dWIndow.cs).