WorldWideTelescope / wwt_kernel_data_relay

A Jupyter Server extension enabling kernels to publish data to predictable URLs
MIT License
1 stars 2 forks source link

Made seq message parameter optional #3

Closed imbasimba closed 2 years ago

imbasimba commented 2 years ago

This is the reason for the 404's and other error events not propagating from jupyter_relay. One could drop the seq requirement like this or make sure that seq is always provided by the user. Judging by the row in jupyter_relay 'seq': seqnum, # this isn't needed by the relay, but can be useful for debugging I think the original idea was to keep this parameter optional, at least for single messages, like errors.

An alternative solution is to force users like jupyter_relay to always send a seq number.