search

WorldWindEarth / WorldWindJava

A community supported fork of the NASA WorldWind Java SDK (WWJ) is for building cross-platform 3D geospatial desktop applications in Java.
https://worldwind.earth/WorldWindJava/
49 stars 14 forks source link

Correct typographical error in DTED Level 2 RPF #20

Closed wcmatthysen closed 5 years ago

wcmatthysen commented 5 years ago

Description of the Change

Migrated the original pull-request from @rhstone (see pull-request: https://github.com/NASAWorldWind/WorldWindJava/pull/98 and the corresponding issue: https://github.com/NASAWorldWind/WorldWindJava/issues/99). According to the original forum-post:

There seems to be duplicate entries in enum RPFDataSeries for DATA_SERIES_D1 and DATA_SERIES_D1. Both have "D1" as and entry for the series code. We are having a problem with world wind displaying the wrong altitude with two different DTED levels. I'm using version 1586.0.0.1. Does anyone know if this is this a known bug? If so, has this been fixed in subsequent versions?

Why Should This Be In Core?

This fixes a bug where WorldWind displays the wrong altitude for two different DTED levels. Looks like a small oversight in the original code.

Benefits

Correct altitude values are displayed for DTED levels.

Potential Drawbacks

None

Applicable Issues

None

wcmatthysen commented 5 years ago

@emxsys, this looks like an oversight in the original code, but I'm not sure as I'm unfamiliar with RPFDataSeries class. Does the fix look OK to you?

emxsys commented 5 years ago

@wcmatthysen I have some RPF data that I will examine.