search

WorldWindEarth / WorldWindJava

A community supported fork of the NASA WorldWind Java SDK (WWJ) is for building cross-platform 3D geospatial desktop applications in Java.
https://worldwind.earth/WorldWindJava/
47 stars 13 forks source link

Removed embedded Jackson sources. #23

Closed wcmatthysen closed 5 years ago

wcmatthysen commented 5 years ago

Description of the Change

Removed the embedded Jackson sources. Instead, an external jackson-core-asl.jar file was added that provides the Jackson parsing functionality.

Why Should This Be In Core?

We should not embed external library sources in WorldWind. External libraries should be included as jar file dependencies. If we decide to switch over to a Maven or Gradle based way of building the project it will be easier to just include Jackson as an external dependency.

Benefits

Less pollution of the code-base with external sources. Easier migration to a newer version of Jackson in the future.

Potential Drawbacks

Users that relied on the embedded version of Jackson transitively (i.e. they received and used Jackson classes via WorldWind as a dependency) will now need to include the jackson-core-asl.jar file on their classpath or potentially encounter class-not-found errors.

Applicable Issues

See issue: https://github.com/WorldWindEarth/WorldWindJava/issues/22

PJHogan commented 5 years ago

Apologies for not being able to contribute, but seeing this project being so lovingly crafted towards a more powerful and welcome place is very exciting! And I know of some government folks who are quite interested in the progress being made here.

wcmatthysen commented 5 years ago

Hi @PJHogan. No problem. It is great to hear that there is some external interest. Any additional interest is always welcome as we need to get a lot more people involved here if we want this project to take off.