search

WorldWindEarth / WorldWindJava

A community supported fork of the NASA WorldWind Java SDK (WWJ) is for building cross-platform 3D geospatial desktop applications in Java.
https://worldwind.earth/WorldWindJava/
47 stars 13 forks source link

MGRS fix #71

Closed gbburkhardt closed 5 years ago

gbburkhardt commented 5 years ago

Note: Filling out this template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainer's discretion.

Description of the Change

Fix two problems: a) Index out of bounds error due to typo in convertMGRSToUPS; clearly the index should have been 1 instead of 12. b) Conversions from geodetic to MGRS would fail for low southern latitudes (zone 0). Geotrans 3.7 has this problem fixed. The WorldWind conversion code was derived from NGA's Geotrans. Test case: Lat: -89.345400 deg, Lon: -48.930600 deg ==> MGRS: AZN 45208 47747

Why Should This Be In Core?

Bug fix

Benefits

Correct conversion from geodetic to MGRS

Potential Drawbacks

Applicable Issues

gbburkhardt commented 5 years ago

How do I see why the build failed?