search

WorldWindEarth / worldwindjs

WorldWindJS is a community maintained fork of the WebWorldWind virtual globe SDK from NASA - an interactive 3D globe library featuring maps, imagery and terrain plus 2D map projections.
https://worldwind.earth/worldwindjs/
38 stars 9 forks source link

Fix failing unit tests #38

Closed emxsys closed 5 years ago

emxsys commented 5 years ago

Several unit tests were fixed in the upstream https://github.com/NASAWorldWind/WebWorldWind/pull/804 PR.

Subtle errors in unit tests fixed. WorldWind's geometric unit tests erroneously modified global variables, such as Location.ZERO. These values shouldn't be encoded as global variables, but solving that is out of scope here. Previous versions of Jasmine concealed this problem but these unit tests fail with Jasmine 3.x, likely due to a change in the Jasmine interpreter lifecycle between tests.

These fixes should be migrated to this fork.

emxsys commented 5 years ago

I forgot that I had already done this. No changes required.