Upgrade to Commerce 2.4.5

douglasg-teachco commented 1 year ago

Hello, we are working on integrating this into a recently upgraded Magento install to 2.4.5.

We are seeing errors such as:

PHP Fatal error:  Declaration of Sapient\AccessWorldpay\Logger\AccessWorldpayLogger::addRecord($level, $message, array $context = []): bool must be compatible with Monolog\Logger::addRecord(int $level, string $message, array $context = [], ?Monolog\DateTimeImmutable $datetime = null): bool in /app/vendor/sapient/module-access-worldpay/Logger/AccessWorldpayLogger.php on line 16

We are also on PHP 8, which is why some of these errors are arising.

Do you all have a timeline on when you plan on updating the extension for 2.4.5 and PHP 8?

Thanks for all you do. :)

Flipmediaco commented 1 year ago

Hi Geoff, this is a duplicate of Issue #9.

Unfortunately there is a bit of a vacuum of communication for this project on here. We have a working version on a Fork that addresses the issue you are seeing along with all other raised issues apart from: #11

The bug fixes have been supplied directly via email by the WP Developers and I have been assured that these will be rolled into the next release 2.4.5. For some reason they are not responding to issues, pull requests or supplying patch files, but only reply via email through our technical contact. For now I have created a Fork so we can deploy via Composer with the "changed files" included.

As I said, one Issue #11 persists and fix is pending from the WP developers. As soon as I have this I will roll this into our Fork.

Hope this helps move your project along.

Thanks

https://github.com/Flipmediaco/Worldpay-Magento2-AW/tree/patch/fix-M2.4.4

Either download or otherwise update composer.json... change version to "dev-patch/fix-M2.4.4" and repro url to: https://github.com/Flipmediaco/Worldpay-Magento2-AW


{
    ...
    "require": {
        ...
        "sapient/module-access-worldpay": "dev-patch/fix-M2.4.4",
        ...
    },
    ...
    "repositories": {
    ...
    "sapient": {
            "type": "git",
            "url": "https://github.com/Flipmediaco/Worldpay-Magento2-AW"
    },
    ...
    },
    ...
    }
}```

douglasg-teachco commented 1 year ago

Thanks so much @Flipmediaco. Sorry for the duplicate. If we find any other issues we will try to contribute what we can.

Worldpay / Worldpay-Magento2-AW

Upgrade to Commerce 2.4.5 #12