search

Worldpay / hybris

Worldpay SAP Hybris Addon
25 stars 32 forks source link

Incorrect spring wiring in worldpaynotifications #112

Closed slav-pilus closed 8 months ago

slav-pilus commented 8 months ago

orderModificationProcessorJobPerformable is using worldpayOrderModificationProcessService for the constructor-arg but it should use it's alias to allow for custom extensions, based on worldpaynotifications to override the logic without the need of changing any of the worldpaynotifications code.

    <bean id="orderModificationProcessorJobPerformable" class="com.worldpay.cronjob.OrderModificationProcessorJobPerformable" parent="abstractJobPerformable">
        <constructor-arg name="worldpayOrderModificationProcessService" ref="worldpayOrderModificationProcessService"/>
    </bean>

should be changed to:

    <bean id="orderModificationProcessorJobPerformable" class="com.worldpay.cronjob.OrderModificationProcessorJobPerformable" parent="abstractJobPerformable">
        <constructor-arg name="worldpayOrderModificationProcessService" ref="orderModificationProcessStrategy"/>
    </bean>
adbame commented 8 months ago

Thank @slav-pilus We are looking into this and will respond to your comments in due course. Thank you for your insight.

adbame commented 8 months ago

Hello @slav-pilus

A new release has been published for versions 2211, 2205 and 2105 fixing this issue