search

WormBase / ACKnowledge

Author Curation to Knowledgebases
MIT License
1 stars 1 forks source link

Strain duplicates #220

Closed draciti closed 3 years ago

draciti commented 3 years ago

One strain was extracted (OH12312) for this paper Tried to add the same strain and see them as duplicates -see screenshot.

Screen Shot 2021-08-24 at 9 05 02 AM

Also, should we add WBstrain IDs next to the strains that were extracted?

valearna commented 3 years ago

Show a message in a popup window when the user adds an entity for which there is an entry with name only already in the box.

valearna commented 3 years ago

Added the error message in a popup only for strains - i.e., the popup is not shown for genes and other datatypes

valearna commented 3 years ago

Modify the form to always get the entity added, including the WBStrainID

valearna commented 3 years ago

Can you test the 'add entity' component again @draciti @vanaukenk and let me know if everything looks good?

vanaukenk commented 3 years ago

@valearna It looks fine to me. Thx. @draciti - do you also want to double-check?

draciti commented 3 years ago

Will do!

From: vanaukenk @.> Sent: Tuesday, September 7, 2021 1:53 PM To: WormBase/author-first-pass @.> Cc: Raciti, Daniela @.>; Mention @.> Subject: Re: [WormBase/author-first-pass] Strain duplicates (#220)

@valearnahttps://github.com/valearna It looks fine to me. Thx. @dracitihttps://github.com/draciti - do you also want to double-check?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/WormBase/author-first-pass/issues/220#issuecomment-914622153, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAG4A64H4N33I36TJH2KY2DUAZ3UDANCNFSM5CW5P5IA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

vanaukenk commented 3 years ago

One other thought. If the Strain autocomplete is empty, but the user clicks on 'Add selected', they still get the message that strains in the final list have been replaced. If the autocomplete field is empty, we should always present the pop-up message about No entities selected.

valearna commented 3 years ago

Thanks @vanaukenk, I'll fix the pop-up messages

valearna commented 3 years ago

@vanaukenk I fixed the pop-up issue

draciti commented 3 years ago

All good, tested both adding new and existing strains, and pop-up functionality. Closing