WormBase / ACKnowledge

Author Curation to Knowledgebases
MIT License
1 stars 1 forks source link

Add logo to emails #258

Closed valearna closed 1 year ago

valearna commented 2 years ago

Try both banner and logo

valearna commented 1 year ago

I was able to add the image but it is also displayed as an attachment and creates issues with caltech spam filters - I'm unable to send emails with images to my caltech account. I think that we should revisit the idea of adding the logo to emails.

draciti commented 1 year ago

Sounds good. We can discuss this tomorrow

azurebrd commented 1 year ago

Are you sending the emails as html with the image in an pointing to the URL of the image ? I haven't used the gmail api much, so I don't know what's possible. Previously sending through sendmail, I think one could send emails as html and then nothing would be an attachment. I realize you wouldn't want to send through sendmail though.

valearna commented 1 year ago

I'm sending the email as html with the image embedded. I read the file from python and add it as a mime image. I think that the way it is displayed depends on the client and with gmail it is displayed both in the email body and as an attachment. There's also the issue that caltech servers are blocking the message, maybe temporarily but it means that there may be more rules for emails with images and I think it's more important to reach the authors and avoid spam filters than having the image in all emails but with the risk of being blocked

azurebrd commented 1 year ago

If it's always the same image, could just hotlink it to the URL instead of mime attaching it ? I guess that wouldn't look good if they view the email without internet connection ? I agree on prioritizing reaching authors, I don't have a stake on this, just wondering technical things. Thanks.

valearna commented 1 year ago

Thanks @azurebrd I haven't thought of adding the image as html. It works, and in this way caltech email server is not blocking the messages!

valearna commented 1 year ago

I deployed the version with the logo to dev but I can switch to the banner depending on what @draciti and @vanaukenk prefer

draciti commented 1 year ago

Pasting the email here for discussion

Screen Shot 2022-08-12 at 10 00 57 AM
draciti commented 1 year ago
Screen Shot 2022-08-12 at 10 10 24 AM
draciti commented 1 year ago

all agree banner is better, need to replace with a smaller one after talking to shannon