search

WormBase / ACKnowledge

Author Curation to Knowledgebases
MIT License
1 stars 1 forks source link

Check behavior for new author flags for Gene model correction/update #33

Closed vanaukenk closed 5 years ago

vanaukenk commented 6 years ago

In testing the afp form, if I check the Gene model corrections/updates box on the Overview page, the corresponding structcorr field in the curation status form is not being updated.

Other fields that are similarly not TPC powered, e.g. RNAseq on the Expression page, do seem to be behaving correctly when checked, so I'm not sure why structcorr is not working.

valearna commented 6 years ago

@vanaukenk Can you give me the ID of the paper that you marked as Gene model corrections/updates positive in the form?

draciti commented 6 years ago

I got the same behavior for WBPaper00053873

draciti commented 6 years ago

@vanaukenk paper was WBPaper00050093. there are some comments on the google doc: https://docs.google.com/document/d/1Q5IqpKuZYQv-8ezUPKsQNP1humtTM92H730AkvD_ReE/edit?ts=5b772087#

valearna commented 6 years ago

I've found the bug with the checkbox value. The problem was that the value saved in the DB was always negative. I've tested it for paper WBPaper00053873 and WBPaper00050093 and changed their values to 'positive'. Can you test it on other papers?

draciti commented 6 years ago

tested on WBPaper00053739, working fine. Closing