search

WormBase / pseudoace

Modelling the WormBase ACeDB database in datomic.
4 stars 3 forks source link

Rename "2-point-data" in model annotations #33

Closed mgrbyte closed 8 years ago

mgrbyte commented 8 years ago

Names starting with non-alphabetic characters cause issues with datalog queries.

We should re-name any class/attribute names in the annotated ACeDB models accordingly.

2-point-data is the only one I'm aware of.

tuli commented 8 years ago

Renaming as two-point-data is fine, genetically more accurate in fact.

Paul-Davis commented 8 years ago

So is this something that needs to be done in the annotated models file or both?

mgrbyte commented 8 years ago

At least in the annotated models; would not need the special syntax (^) if applied to the ACeDB model first.

mgrbyte commented 8 years ago

@Paul-Davis @tuli Is this something that could go into WS255?

tuli commented 8 years ago

I believe so. @Paul-Davis would you like me to write a proposal to models?

Paul-Davis commented 8 years ago

@tuli is 2-point-data used in acedb tools/displays where this change would break the functionality?

;)

tuli commented 8 years ago

Do you mean like the genetic map?

What do you mean custom? Isn't everything in acedb custom made?

Paul-Davis commented 8 years ago

@tuli yes things like genetic map.

Paul-Davis commented 8 years ago

I don't believe this is resolved??!

mgrbyte commented 8 years ago

@Paul-Davis Seems to have been done in the annotated models?

Paul-Davis commented 8 years ago

2-point-data model hasn't been touched since before you collapsed the WSXYZ model files down into a single file for tracking differences (version control vs versions of the file).

mgrbyte commented 8 years ago

Looks like it was actually previously done (as far back as WS249) https://github.com/WormBase/pseudoace/blame/master/models/models.wrm.annot#L897

Paul-Davis commented 8 years ago

I'll close it again then as it was a non-issues ;)