search

WormBase / pseudoace

Modelling the WormBase ACeDB database in datomic.
4 stars 3 forks source link

#address institution is :boolean instead of :string #57

Closed azurebrd closed 7 years ago

azurebrd commented 7 years ago

https://github.com/WormBase/pseudoace/blob/master/generated-schemas/schema256.edn#L3450

mgrbyte commented 7 years ago

@Paul-Davis I've compared models.wrm.annot to models.wrm, the former is missing the type annotation Text on the Institution tag which is causing this. Do you know of any reason why this would be dropped?

"Bare" leaf tags such as this will be converted to boolean.

mgrbyte commented 7 years ago

Looks like this was accidentally removed between the following revisions (when the models file used to live in this repository):

commit c9fadb95458ea958ddc8afb69be01f53a32bb47c
Author: Matt Russell <matt@mgrbyte.co.uk>
Date:   Tue Apr 5 10:02:43 2016 +0100

    Update text to reflect name change and cleanup.

commit 5426ab4ba70ea435c13dd3075ea1798beeb9d419
Author: Matt Russell <matt@mgrbyte.co.uk>
Date:   Tue Apr 5 10:27:37 2016 +0100

    Unified models file.

I'll commit a fix to the models.wrm.annot file in wormbase-pipeline.

mgrbyte commented 7 years ago

This has been fixed and should be available/visible in WS258.

azurebrd commented 7 years ago

Thanks Matt.