search

WormBase / pseudoace

Modelling the WormBase ACeDB database in datomic.
4 stars 3 forks source link

Missing data in WS258 onwards #71

Closed mgrbyte closed 7 years ago

mgrbyte commented 7 years ago

The change made to address #54 has resulted in data being missing from some person entities in the migrated datomic database.

The Institution tag in the #Address model in the annotated models was changed to be UNIQUE Text when it should have been just Text.

The importer is silently swallowing exceptions which meant they were not being noticed (or written to a log file on the migration machine).

The effect being that although the entity exists for e.g WBPerson2987, it only contains reference attributes, and none of the scalar ones (e.g first-name, last-name et al) - this being due to the failed transactions caused by there being duplicate :address/institution values in the data, but the model attempting to state they are unique.

mgrbyte commented 7 years ago

Fixed import process in 0853b93fb2d3d9384efd605db946a0a1121ba1e8

Fixed annotated models.

azurebrd commented 7 years ago

Thanks @mgrbyte I can see the Institution data at http://rest-dev.wormbase.org:8888/browse I'll patch the Person overview sometime soon

mgrbyte commented 7 years ago

@azurebrd pls wait for WS259 to be migrated and made available before making the changes - the institution data currently in datomic for WS258 is incomplete.

azurebrd commented 7 years ago

Ah, got it, I thought that was a longer explanation of what had gotten fixed for the release, as opposed to a new bug being fixed for a future release. Thanks @mgrbyte