search

Wouter01 / MediaMate-Releases

82 stars 0 forks source link

Songs with some type of artwork crash the app #22

Closed macsen0 closed 8 months ago

macsen0 commented 9 months ago

Describe the bug Some songs crash the app. Managed to figure is the artwork, since some of these songs are mine and uploaded a long time ago. I'm not sure what is the problem with the image, but it crashes the app.

To Reproduce Steps to reproduce the behavior:

  1. Play a song with the artwork that crashes the app.
  2. The App crashes.

Expected behavior Obviously, it should not crash, but if the thumbnails are the culprits, the app should ignore them.

Please complete the following information: — OS: Sonoma 14.2.1 — MacBook Pro M1 Pro

Additional context It's just weird. And it would be very impractical to check all of my songs to see what crashes the app and what does not. Probably check the thumbnail implementation?

Wouter01 commented 9 months ago

Thank you for the bug report. Would it be possible to attach the file / artwork you're experiencing issues with?

macsen0 commented 9 months ago



That one does it… copied pasted it from Music (seems like there are the ancient CD rips I did a long time ago)

If you need, I can send you a song too

Rick Robles http://rickrobles.myportfolio.com

On 26 Dec 2023, at 16:15, Wouter Hennen @.***> wrote:

Thank you for the bug report. Would it be possible to attach the file / artwork you're experiencing issues with?

— Reply to this email directly, view it on GitHub https://github.com/Wouter01/MediaMate-Releases/issues/22#issuecomment-1869797616, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQXGQPEYZRPZX233U5LNOY3YLNEBDAVCNFSM6AAAAABBDQNU4OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZG44TONRRGY. You are receiving this because you authored the thread.

Wouter01 commented 9 months ago

Unfortunately I can't see any image / file in your reply. Could you try sending the artwork / music via email to media.mate@icloud.com ? Thank you!

Wouter01 commented 9 months ago

Thank you for the mail. I've had a look and the crash happens in Apple's ScriptingBridge framework. This issue also affects other apps using the same framework. The next version of the app does not use this framework anymore and therefore does not have this issue. So I will keep this issue open for now, but once that version has been released I will close it.

macsen0 commented 9 months ago

Thank you very much… I’ll be waiting that next version.

Keep the amazing work!

Rick

Rick Robles http://rickrobles.myportfolio.com

On 27 Dec 2023, at 9:29, Wouter Hennen @.***> wrote:

Thank you for the mail. I've had a look and the crash happens in Apple's ScriptingBridge framework. This issue also affects other apps using the same framework. The next version of the app does not use this framework anymore and therefore does not have this issue. So I will keep this issue open for now, but once that version has been released I will close it.

— Reply to this email directly, view it on GitHub https://github.com/Wouter01/MediaMate-Releases/issues/22#issuecomment-1870408101, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQXGQPGEX6LZUB6WFBRGBM3YLQ5FBAVCNFSM6AAAAABBDQNU4OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZQGQYDQMJQGE. You are receiving this because you authored the thread.

Wouter01 commented 8 months ago

A new version has been released which fixes this issue.