Wouter01 / MediaMate-Releases

82 stars 0 forks source link

Glitch when Auto-minimize on Notch-MBP-14" #50

Open Ender-Wang opened 7 months ago

Ender-Wang commented 7 months ago

Describe the bug There is a small glitch/jump when it minimizes. See the video, pay attention to the last two seconds.

To Reproduce Steps to reproduce the behavior: Click the next or previous song at the end of the animation changes. Device: MacBook Pro 14" M3 Max, macOS 14.4 public beta 5 (23E5211a).

Awesomeplayer165 commented 7 months ago

I can confirm this also happens.

Bhanu1776 commented 6 months ago

Yeah, this happens for me too! It takes a second to settle down.

Ender-Wang commented 6 months ago

Most likely it's related to the corner radius since I saw the update log of the latest 3.1.3 update suggested a change there. Visually, the notch on 14" MBP has two different radii between the top two corners and the bottom two.

Wouter01 commented 6 months ago

Did this also happen in the previous version? I might need to make some adjustments. I don't have a macbook with a notch myself, making these things hard to test

Ender-Wang commented 6 months ago

Did this also happen in the previous version? I might need to make some adjustments. I don't have a macbook with a notch myself, making these things hard to test

Just tested the previous two versions, and the same glitch exists.

Ender-Wang commented 6 months ago

Did this also happen in the previous version? I might need to make some adjustments. I don't have a macbook with a notch myself, making these things hard to test

Not sure whether Apple provides the exact dimension of the notch on 14/16", but I am guessing that the default/minimal notch dimension on your code is slightly bigger than the actual physical size based on the observed behavior, feels like 0.2-0.5 cm bigger. Maybe that's why when the animation ends and the notch rectangle disappears caused the glitch.

Ender-Wang commented 6 months ago

Did this also happen in the previous version? I might need to make some adjustments. I don't have a macbook with a notch myself, making these things hard to test

Just found out that in the demo gif on MediaMate Homepage, the glitch also showing, zoom in and it'r more obvious, the MacBook frame on that site is accurate.

Wouter01 commented 6 months ago

Did this also happen in the previous version? I might need to make some adjustments. I don't have a macbook with a notch myself, making these things hard to test

Not sure whether Apple provides the exact dimension of the notch on 14/16", but I am guessing that the default/minimal notch dimension on your code is slightly bigger than the actual physical size based on the observed behavior, feels like 0.2-0.5 cm bigger. Maybe that's why when the animation ends and the notch rectangle disappears caused the glitch.

The size of the notch is calculated based on the size of some parameters that the systems report, so it should be pretty accurate. This is most likely caused by some part of the animation. I'm also not sure if the calculations of the size of the notch are accurate for all display resolution / zoom configurations.

What I can tell, is that I did change the calculation method for the notch for MediaMate v3. In MediaMate v2, the notch size is a tiny bit smaller than the actual size, so I might add that back. I don't know if it's possible for you to test v2.5.1? (It would help me out a lot!). Going back might alter some of your settings though, as they changed in v3, so don't feel pressured to do it.

Ender-Wang commented 6 months ago

Did this also happen in the previous version? I might need to make some adjustments. I don't have a macbook with a notch myself, making these things hard to test

Not sure whether Apple provides the exact dimension of the notch on 14/16", but I am guessing that the default/minimal notch dimension on your code is slightly bigger than the actual physical size based on the observed behavior, feels like 0.2-0.5 cm bigger. Maybe that's why when the animation ends and the notch rectangle disappears caused the glitch.

The size of the notch is calculated based on the size of some parameters that the systems report, so it should be pretty accurate. This is most likely caused by some part of the animation. I'm also not sure if the calculations of the size of the notch are accurate for all display resolution / zoom configurations.

What I can tell, is that I did change the calculation method for the notch for MediaMate v3. In MediaMate v2, the notch size is a tiny bit smaller than the actual size, so I might add that back. I don't know if it's possible for you to test v2.5.1? (It would help me out a lot!). Going back might alter some of your settings though, as they changed in v3, so don't feel pressured to do it.

2.5.1 does not have such a glitch, confirmed. Maybe making it smaller than actual size is the easiest way to tackle it. Perhaps give us an opt to change it manually if someday Apple shrinks the notch and I am pretty sure Apple will shrink it, sooner or later.

Wouter01 commented 6 months ago

Noted! Thank you for testing this. I will revert the calculation to the old method. This should still work if Apple would shrink the size of the notch, as it's calculated based on what the system reports. I will also see if it's possible to add an option in the app to further change the size of the notch if the calculation would still not be correct. I will update the thread when an update is released which fixes the issue.

Ender-Wang commented 6 months ago

Noted! Thank you for testing this. I will revert the calculation to the old method. This should still work if Apple would shrink the size of the notch, as it's calculated based on what the system reports. I will also see if it's possible to add an option in the app to further change the size of the notch if the calculation would still not be correct. I will update the thread when an update is released which fixes the issue.

One more suggestion on the title display mode on notch-style, sometimes(when watching episodes or ytb videos), the full title is longer than the UI width, instead of trimming the tail with "...", maybe let the full title cycle through the display portion would be a better and more elegant solution.

One more thing about the "Unknown" keyword, maybe display App Name if it's not music artist or ytb Channel Name. Or just leave it blank, instead of showing "Unkown."

CleanShot_2024-03-05_18-28-14

Regarding the opt of notch width, maybe just Dynamic would be enough since the UI would look good if it plays music vs. ytb video with a long title. Just my take, since I always leave it as dynamic, plus there's some UI mis-alignment in static mode (I know it's still in Beta).

A great app that makes me feel like it's stock on macOS! Much appreciation.

Wouter01 commented 6 months ago

Thank you for the additional feedback. I'll remove the "Unknown" in the next update of the app. I will look into the possibility to have a sliding title (It would be kinda tricky to add when also having a dynamic width)

Ender-Wang commented 6 months ago

One more alignment parameter, the last one of today, I promise LMAO. CleanShot_2024-03-05_18-42-15

Wouter01 commented 6 months ago

I have reverted some changes. Could someone with a macbook with a notch check if this new build still has the issue? MediaMate.zip

Ender-Wang commented 6 months ago

I have reverted some changes. Could someone with a macbook with a notch check if this new build still has the issue? MediaMate.zip

The two bottom corners are perfect now, but I noticed a tinny bit jump on the two top corners, a few pixels are still moving when the animation ends.

Wouter01 commented 6 months ago

Could you show an updated video of the issue?

Ender-Wang commented 6 months ago

https://github.com/Wouter01/MediaMate-Releases/assets/33310255/23319f9e-e5d4-4191-bf76-650373a3e853

Pay attention to the last second.

Wouter01 commented 6 months ago

A new update has been released which contains the earlier fix for the notch size. The top corner radiuses are not changed in the new update, I will have a look at it soon.